Chat module migration #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #2195: Migrate Chat module in App to use the new backend server / GraphQL. |
stoneman1
reviewed
Jun 16, 2023
| @@ -23,7 +23,7 @@ export class SellerProfileDto { | |||
| reviews?: string[]; | |||
|
|
|||
| @Field(() => Boolean, { nullable: true }) | |||
| hasMadeApprovedRequest?: boolean; | |||
| hasMadeApprovedRequest?: boolean; // Todo: remove it | |||
There was a problem hiding this comment.
@stoneman1 I'll remove it, but we should remove it from iWeb first. (I didn't add it to the app yet, so it's here only to not break anything on iWeb)
There was a problem hiding this comment.
I will remove this in another PR
mairh
force-pushed
the
improvement/chat_module
branch
from
c408032 to
dfcf946
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.shortcut.com/helpdor/story/2195/migrate-chat-module-in-app-to-use-the-new-backend-server-graphql