Feat/add graphql settings #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 16, 2023 15:53
mairh
reviewed
Jun 16, 2023
| import { Field, ObjectType } from '@nestjs/graphql'; | ||
|
|
||
| @ObjectType() | ||
| export class LangObj { |
There was a problem hiding this comment.
Could we use more telling names like DictionaryDto?
There was a problem hiding this comment.
It would be good to place object types in separate files in the dto subfolder
mairh
reviewed
Jun 16, 2023
| @@ -0,0 +1,4 @@ | |||
| export interface ISettings { | |||
There was a problem hiding this comment.
Could we get rid of the prefix "I"? "Settings" is enough
|
@stoneman1 Added some small comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the graphql part for settings module.
@mairh can you check that its ok?
https://app.shortcut.com/helpdor/story/2196/migrate-setting-module-in-app-to-use-the-new-backend-server-graphql