fix incorrect syscall usage in tester/mapping1 test #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
/app/tester
'smapping1
test case,NULL
is passed into theas_get_physical_mapping
syscall.This results in the syscall correctly returning
EPERM
, as down the call stack the return value is determined by(as
memcpy_to_uspace
returns0
on failure) and the (unexpected) failure of the test case.As this use of the syscall (passing
NULL
as the onlyout
argument) is not reflective of real usage,I only adjusted the call site. I also fixed a comment in the assembly which seems incorrect according
to System V x86-64 ABI.