Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api test #2

Merged
merged 10 commits into from
Apr 21, 2024
Merged

Api test #2

merged 10 commits into from
Apr 21, 2024

Conversation

Tosiekdev
Copy link
Contributor

No description provided.

@Tosiekdev Tosiekdev requested a review from michalszc April 21, 2024 16:33
Copy link
Contributor

@michalszc michalszc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect

if errResp := validator.ToErrResponse(err); errResp == nil || len(errResp.Errors) != 1 {
t.Fatalf(`Expected:"{[%v]}", Got:"%v"`, tc.expected, errResp)
if errResp := validator.ToErrResponse(err); errResp == nil || (len(errResp.Errors) != 1 && tc.name != "required_without") {
t.Fatalf(`Przyp a, Expected:"{[%v]}", Got:"%v"`, tc.expected, errResp)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
t.Fatalf(`Przyp a, Expected:"{[%v]}", Got:"%v"`, tc.expected, errResp)
t.Fatalf(`Expected:"{[%v]}", Got:"%v"`, tc.expected, errResp)

Copy link
Contributor

@michalszc michalszc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Tosiekdev Tosiekdev merged commit a96f32b into master Apr 21, 2024
@Tosiekdev Tosiekdev deleted the api-test branch April 21, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants