Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/physical apertures #81

Merged
merged 30 commits into from
Feb 23, 2025
Merged

Feat/physical apertures #81

merged 30 commits into from
Feb 23, 2025

Conversation

HarrisonKramer
Copy link
Owner

  • Add new physical apertures: rectangular, elliptical, polygon, file
  • Add new aperture logic to enable Boolean operations
  • Update 3D plotting for non-rotationally symmetric surfaces
  • Add tests and update docs

@HarrisonKramer HarrisonKramer linked an issue Feb 23, 2025 that may be closed by this pull request
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

Attention: Patch coverage is 85.09934% with 45 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
optiland/visualization/surface.py 11.11% 32 Missing ⚠️
optiland/physical_apertures/base.py 88.88% 10 Missing ⚠️
optiland/physical_apertures/polygon.py 95.16% 3 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   96.57%   96.20%   -0.38%     
==========================================
  Files         105      111       +6     
  Lines        6340     6583     +243     
==========================================
+ Hits         6123     6333     +210     
- Misses        217      250      +33     
Files with missing lines Coverage Δ
optiland/optic.py 98.10% <100.00%> (ø)
optiland/physical_apertures/__init__.py 100.00% <100.00%> (ø)
optiland/physical_apertures/elliptical.py 100.00% <100.00%> (ø)
optiland/physical_apertures/offset_radial.py 100.00% <100.00%> (ø)
optiland/physical_apertures/radial.py 100.00% <100.00%> (ø)
optiland/physical_apertures/rectangular.py 100.00% <100.00%> (ø)
optiland/physical_apertures/polygon.py 95.16% <95.16%> (ø)
optiland/physical_apertures/base.py 88.88% <88.88%> (ø)
optiland/visualization/surface.py 55.43% <11.11%> (-9.44%) ⬇️

... and 4 files with indirect coverage changes

@HarrisonKramer HarrisonKramer merged commit 9427c5b into master Feb 23, 2025
6 checks passed
@HarrisonKramer HarrisonKramer deleted the feat/physical_apertures branch February 23, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-circular apertures
1 participant