[Issue #3764] add search query params to new relic #4039
+366
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t not setting yet
doug-s-nava
force-pushed
the
dschrashun/3764-new-relic-query-params
branch
from
2fda842 to
a807453
Compare
doug-s-nava
commented
Feb 27, 2025
| export const metadata: Metadata = { | ||
| icons: [`${environment.NEXT_PUBLIC_BASE_PATH}/img/favicon.ico`], | ||
| }; | ||
|
|
||
| type NRType = typeof newrelic; |
There was a problem hiding this comment.
moved this stuff to a types file
doug-s-nava
commented
Feb 27, 2025
| @@ -64,16 +64,19 @@ export interface SearchAPIResponse extends APIResponse { | |||
| fieldChanged?: string; | |||
| } | |||
|
|
|||
| export const validSearchQueryParamKeys = [ | |||
There was a problem hiding this comment.
wanted to be able to use these values for whitelisting / iteration, so switched up a bit of the typing here
doug-s-nava
commented
Feb 27, 2025
| @@ -66,6 +66,7 @@ | |||
| "@types/js-cookie": "^3.0.6", | |||
| "@types/lodash": "^4.17.13", | |||
| "@types/newrelic": "^9.14.6", | |||
| "@types/new-relic-browser": "^1.230.5", | |||
There was a problem hiding this comment.
used implicitly to provide a type for window.newrelic
doug-s-nava
changed the title
doug-s-nava
requested review from
acouch,
coilysiren,
mdragon,
andycochran,
btabaska and
freddieyebra
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3764
Time to review: 15 mins
Changes proposed
Context for reviewers
Note that custom attributes are being cleared when navigating away from the search page, but not quickly enough for them to not show up on the route transition events on navigation. Not sure if this is a deal breaker.
Also note that I've discovered that trying to run the app with new relic enabled but without an app name or license key results in the application hanging indefinitely. We should fix this in a future ticket.
Further note that given the somewhat vague requirements in the ticket I've just tried to make sure here that all the necessary data is making it into new relic, as much as possible. I created a basic dashboard view of a query to show the new parameters, but anything other work on this should probably go in another ticket. I attempted to make the query more flexible, by querying for all attributes with the
search_paramprefix, so far with no luck;.Documentation updates are in order, but need to wait for #4005 with larger documentation updates to come in first
Related docs
Test steps
npm run build -- --no-lint && NEW_RELIC_APP_NAME="Simpler Grants Next DEV" NEW_RELIC_LICENSE_KEY="<license key from 1password>" npm run start:nrAdditional information