new version for implementation of smaller beam pipe

[aciarma]

Version to implement the new beam pipe (central part radius=10mm length=18cm).

For the moment I only had to fix the VXD volume definition, as it was depending on the CentralBeamPipe_zmax instead of VertexBarrel_zmax. This caused the innermost layer of the barrel to exit the volume when reducing the central beam pipe half-length.

As for now the VXD is unchanged, but some modifications should be performed in order to benefit of the smaller beam pipe (i.e. have the detector closer to the IP, both radially and longitudinally).

[aciarma]

Changed the thickness of the central chamber to 1.7mm (same thickness of engineered design even if different material). Changed the dimensions of the VXD Barrel in order to fit the small beam pipe, as per previous discussion with detector experts. The distance between beam pipe and first layer has been kept the same. The length of the layers has been set to keep the same angular acceptance of the previous version. The number of staves and the offset has been adjusted to fit the new small radius for the first and second Double Layers (outermost DL untouched).

[gganis]

Hi Andrea,
A very late reaction on this.
Looks good. Question: why the renaming o2_v02 -> o1_v04 ? For consistency with lcgeo ?

[vvolkl]

Yes, indeed, this model is based on o1 of CLD, and calling it o2 has already caused confusion

[andresailer]

Are these now the same as the lcgeo versions of these detectors with the same name?

[vvolkl]

@aciarma Why are all the supports removed here?

[aciarma]

Hi Valentin, I dont know I never touched the OT.
It is actually like this also in the o2_v02 repo (which is where I started from).

[vvolkl]

Should be

Suggested change

	<detector name="InnerTrackerBarrelSupport" type="TrackerBarrelSupport_o1_v01" id="0" reflect="true" region="InnerTrackerBarrelRegion">
	<detector name="InnerTrackerBarrelSupport" type="TrackerBarrelSupport_o1_v02" id="0" reflect="true" region="InnerTrackerBarrelRegion">

see key4hep/k4geo#259

[aciarma]

Hi Valentin,

modifying this to v02 i get an error when building the detector: "No factory with name Create(TrackerBarrelSupport_o1_v02) for type TrackerBarrelSupport_o1_v02 found."

what am I missing?

[vvolkl]

See comment above

[vvolkl]

This file (and the other additions to DetCommon) should go as well to FCCee_o1_v05, I think

[aciarma]

I think the beampipe should be common for all of the experiments, so it should not go in the DetFCCeeCLD folder but stay in DetFCCeeCommon, right?

[EmanuelPerez]

Hi Valentin, Andrea, I do not know what had been the starting point here. I remember that some time ago (2.5 yrs or so) I had temporarily removed the supports because I had issues with the corresponding drivers. Chances are that these were just related to a wrong setup or environment. And I think that these structures should be put in indeed. Cheers, E. On 6 Dec 2022, at 17:01, Valentin Volkl ***@***.******@***.***>> wrote: @vvolkl commented on this pull request.

________________________________ In Detector/DetFCCeeCLD/compact/FCCee_o1_v05/InnerTracker.xml<#20 (comment)>:

+ <ring r="InnerTracker_Endcap_radius_5" zstart="InnerTracker_Endcap_z_5" nmodules="24" dz="3*mm" module="InnerTrackerEndcapModule_7x5_In" phi0="0"/>

+ <ring r="InnerTracker_Endcap_radius_5+5*ITM" zstart="InnerTracker_Endcap_z_5" nmodules="24" dz="3*mm" module="InnerTrackerEndcapModule_9x8_In" phi0="0"/> + <ring r="InnerTracker_Endcap_radius_5+13*ITM" zstart="InnerTracker_Endcap_z_5" nmodules="24" dz="3*mm" module="InnerTrackerEndcapModule_10x4_In" phi0="0"/> + <ring r="InnerTracker_Endcap_radius_5+17*ITM" zstart="InnerTracker_Endcap_z_5" nmodules="24" dz="3*mm" module="InnerTrackerEndcapModule_11x6_In" phi0="0"/> + </layer> + + <layer id="6"> + <ring r="InnerTracker_Endcap_radius_6" zstart="InnerTracker_Endcap_z_6" nmodules="24" dz="3*mm" module="InnerTrackerEndcapModule_7x5_Out" phi0="0"/> + <ring r="InnerTracker_Endcap_radius_6+5*ITM" zstart="InnerTracker_Endcap_z_6" nmodules="24" dz="3*mm" module="InnerTrackerEndcapModule_9x3_Out" phi0="0"/> + <ring r="InnerTracker_Endcap_radius_6+8*ITM" zstart="InnerTracker_Endcap_z_6" nmodules="24" dz="3*mm" module="InnerTrackerEndcapModule_9x5_Out" phi0="0"/> + <ring r="InnerTracker_Endcap_radius_6+13*ITM" zstart="InnerTracker_Endcap_z_6" nmodules="24" dz="3*mm" module="InnerTrackerEndcapModule_12x8_Out" phi0="0"/> + </layer> + + </detector> + +<!-- @aciarma<https://github.com/aciarma> Why are all the supports removed here? — Reply to this email directly, view it on GitHub<#20 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABI7YBFBEQR3BKQVXNFLKXDWL5POXANCNFSM5VOAF5SQ>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[aciarma]

I reverted back to v01 the type of the tracker support as when compiling the factory for the v02 couldn't be found.
Also, as my pull request did not concern the trackers from the start, but only the vertex detector adaptation for the central chamber (which now is R=10mm L=18cm, and it is what it should be used also for the other detectors like IDEA), I hope it can be approved.

Further fixes - like the naming conventions, supports, and so on - can be applied in the future with other pull requests.

[BrieucF]

Hi @aciarma ! Is this PR ready to be merged on your side?

[aciarma]

Hi @aciarma ! Is this PR ready to be merged on your side?

Hi @BrieucF, yes for me this is ready