Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material_social): use cards_dir to build cards url for page #354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kanru
Copy link

@kanru kanru commented Feb 25, 2025

@github-actions github-actions bot added the bug Something isn't working label Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.46%. Comparing base (c2525f5) to head (0370428).
Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #354      +/-   ##
==========================================
+ Coverage   81.12%   81.46%   +0.34%     
==========================================
  Files          11       11              
  Lines         747      750       +3     
  Branches      125      124       -1     
==========================================
+ Hits          606      611       +5     
+ Misses         97       96       -1     
+ Partials       44       43       -1     
Flag Coverage Δ
unittests 81.46% <100.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lugin/integrations/theme_material_social_plugin.py 76.61% <100.00%> (+2.23%) ⬆️

... and 3 files with indirect coverage changes

@Guts
Copy link
Owner

Guts commented Feb 25, 2025

Hi @kanru ,

Thanks for your PR!

Sorry, CI was broken so I've fixed it in #357. Can you rebase your branch on origin/main please?

Can you also apply contributing guidelines, to make pre-commit.ci happy? I'll review it once everything is green here :).

@kanru kanru force-pushed the fix-material-social-cards branch from 571701e to 0370428 Compare February 25, 2025 22:26
@kanru
Copy link
Author

kanru commented Feb 27, 2025

@Guts done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Material social cards not working with customized social.cards_dir directory
2 participants