Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[next][dace]: Update cuda codegen for concat_where #1906

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Mar 7, 2025

We use CopyToMap in CUDA lowering for copies between arrays that do not necessarily have the same strides. This happens in case of concat_where, where we copy a source array into a subset of the destination array.

For this reason, the option ignore_strides must be set to True (False by default).

Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@philip-paul-mueller philip-paul-mueller self-requested a review March 7, 2025 13:02
Copy link
Contributor

@philip-paul-mueller philip-paul-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

philip-paul-mueller added a commit to philip-paul-mueller/gt4py that referenced this pull request Mar 7, 2025
This reverts commit 77e1c20.
As it has become obsolte with [PR#1906](GridTools#1906).
@edopao edopao changed the title fix[next][dace]: dace cuda codegen for concat_where fix[next][dace]: Update cuda codegen for concat_where Mar 7, 2025
@edopao edopao merged commit 629a073 into GridTools:main Mar 7, 2025
23 checks passed
@edopao edopao deleted the dace-copy_to_map branch March 7, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants