refactor[next]: new ITIR type inference #1531

tehrengruber · 2024-04-17T19:42:24Z

New type inference algorithm on ITIR unifying the type system with the one used in the frontend. Types are stored directly in the ITIR nodes. This replaces the constraint based type inference giving significant performance and usability improvements. Types of builtins are expressing using simple to write TypeSynthesizer of the form:

@_register_builtin_type_synthesizer
def power(base: ts.ScalarType, exponent: ts.ScalarType) -> ts.ScalarType:
    return base

…ir.Ref. (#1532) In the new ITIR type inference #1531 IR nodes store their type in the node itself. While we initially exclude the attribute from equality comparison we should nonetheless avoid comparison of nodes that only differ in type. This PR removes many of this occurrences.

egparedes

First round of review. I focused mainly in general python aspects and skipped the tests and an in-depth review of the type inference algorithm itself, which I'll do in a following review.

src/gt4py/next/ffront/type_info.py

src/gt4py/next/iterator/ir.py

src/gt4py/next/iterator/ir_utils/ir_makers.py

src/gt4py/next/iterator/transforms/symbol_ref_utils.py

src/gt4py/next/iterator/type_system/inference.py

egparedes

Just minor comments. I'm still thinking about the idea of transforming the inference algorithm to use a graph instead of callbacks, but it might be out of scope for this PR.

src/gt4py/next/iterator/type_system/inference.py

src/gt4py/next/iterator/type_system/type_specifications.py

src/gt4py/next/iterator/type_system/type_synthesizer.py

src/gt4py/next/iterator/type_system/type_specifications.py

src/gt4py/next/iterator/type_system/type_synthesizer.py

src/gt4py/next/iterator/type_system/type_specifications.py

src/gt4py/next/iterator/type_system/inference.py

egparedes

It looks good. I think it's better to merge the PR now and keep thinking about ways to simplify or improve the inference algorithm in other PRs.

egparedes · 2024-06-25T07:12:42Z

Don't forget to add a proper PR description before merging.

In #1531 the `itir.Node` class got a `type` attribute, that until now contributed to the hash computation of all nodes. As such two `itir.SymRef` with the same `id`, but one with a type inferred and one without (i.e. `None`) got a different hash value. Consequently the `inline_lambda` pass did not recognize them as a reference to the same symbol and erroneously inlined the expression even with `opcount_preserving=True`. This PR fixes the hash computation, such that again `node1 == node2` implies `hash(node1) == hash(node2)`.

tehrengruber added 10 commits April 15, 2024 07:45

Use type specification for itir.Literal

aa937da

Small cleanup

095ae13

Small fix

cace41a

Fix failing doctests

b22f929

Address review comments

288ea3c

New type inference first draft

c695935

Merge origin/main

72b50ff

Fix some tests

beabac2

Cleanup

ed4bf27

Use is_call_to instead of equality comparison with itir.Ref.

1c94bf0

tehrengruber mentioned this pull request Apr 18, 2024

refactor[next]: Use is_call_to instead of equality comparison with itir.Ref. #1532

Merged

tehrengruber added 8 commits April 18, 2024 10:47

Cleanup

3799b7a

Cleanup

f75f0e4

Address reviewer comments

779ba3d

Cleanup

c7e1e93

Merge origin_tehrengruber/fix_im_ref_comp

172982f

Cleanup

79bee51

Cleanup

dd5e601

Merge origin_tehrengruber/fix_im_ref_comp

1b803b7

tehrengruber added 10 commits April 18, 2024 15:30

Merge origin_tehrengruber/fix_im_ref_comp

f41e032

Merge origin/main

520c805

Add test for neighbor / sparse input field

129f6b3

Multiple fixes

a99ca9a

Multiple fixes

896582e

Cleanup

c8fb2d9

Cleanup

cb0ebbb

Fix dace

873c60e

Formatting

d42fa12

Formatting

8c632de

tehrengruber requested a review from egparedes April 24, 2024 07:37

tehrengruber added 13 commits April 24, 2024 13:14

Add documentation

9535e72

Merge origin/main

2340907

Remove debug code

d9a772c

Fix temporary codegen in roundtrip

5db67fc

Formatting

2d28181

Cleanup

09006e9

Add support for new itir.Program format

7ebb257

Small fixes

b23454d

Fix list_get

953658a

Fix typing and SetAt type check

2dba9cf

Fix program

233c369

Fix program

f9dd78b

Fix gtfn_module test

18ab7a4

egparedes requested changes May 3, 2024

View reviewed changes

Address review comments

5947934

egparedes reviewed May 15, 2024

View reviewed changes

src/gt4py/next/iterator/type_system/inference.py Outdated Show resolved Hide resolved

Cleanup

fb6fac5

tehrengruber requested a review from egparedes June 10, 2024 09:52

tehrengruber added 2 commits June 10, 2024 13:22

Small fix

7971fff

Fix doctest

876d3df

egparedes reviewed Jun 20, 2024

View reviewed changes

Address reviewer comments

88c4f0d

tehrengruber requested a review from egparedes June 21, 2024 12:14

egparedes approved these changes Jun 25, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into itir_type_inference

6bcc38a

tehrengruber merged commit 3dfbf3f into GridTools:main Jun 27, 2024
31 checks passed

tehrengruber mentioned this pull request Oct 10, 2024

[next]: Fix inline lambda pass opcount preserving option #1687

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor[next]: new ITIR type inference #1531

refactor[next]: new ITIR type inference #1531

tehrengruber commented Apr 17, 2024 •

edited

Loading

egparedes left a comment

egparedes left a comment

egparedes left a comment

egparedes commented Jun 25, 2024

refactor[next]: new ITIR type inference #1531

refactor[next]: new ITIR type inference #1531

Conversation

tehrengruber commented Apr 17, 2024 • edited Loading

egparedes left a comment

Choose a reason for hiding this comment

egparedes left a comment

Choose a reason for hiding this comment

egparedes left a comment

Choose a reason for hiding this comment

egparedes commented Jun 25, 2024

tehrengruber commented Apr 17, 2024 •

edited

Loading