feat[next][dace]: Add support for if expressions with tuple argument #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better solution is to extend the ITIR pass to unpack tuple args (awaiting GridTools#1350)
kotsaloscv
approved these changes
Dec 12, 2023
edopao
added a commit
to edopao/gt4py
that referenced
this pull request
Dec 12, 2023
Left-over from PR GridTools#1393
havogt
pushed a commit
that referenced
this pull request
Dec 12, 2023
Fix for broken DaCe test in baseline: - use `flatten_list` to get `ValueExpr` arguments to numeric builtin function Additionally, enable test for DaCe backend (left-over from PR #1393).
edopao
added a commit
to edopao/gt4py
that referenced
this pull request
Dec 13, 2023
Left-over from PR GridTools#1393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some icon4py stencils require support for
ifexpressions with tuple arguments. This PR adds support to the DaCe backend in the visitor ofbuiltin_iffunction.Additionally, this PR contains one fix in the result of
builtin_tuple_get, which should return a list.