feat[next]: Separates ITIR -> SDFG translation from running #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erator` and related problems. GT4Py started to exhibit an issue (out of bounds access) with the introduction of [PR1457](spcl/dace#1457). The commit fixes this, by creating the proper arguments and ensuring that the memory it operates on is continuous and proper allocated.
I realized that the copy is unnecessary. The reason of the original memory problems was outside GT4Py and located in my driver code. The copy just fixed that internally, but was from the beginning a bad solution.
By default this function used the prefix `__var`, however, since everything with two leading underscores is considered by DaCe to be internal this could potentially lead to a name clash. Thus I changed this to `_var`.
edopao
reviewed
Nov 30, 2023
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
This makes it easier to experiment with the SDFG that were generated from the stencil.
philip-paul-mueller
force-pushed
the
separating_creation_running_sdfg
branch
from
a8cdee0 to
d5d5255
Compare
edopao
reviewed
Dec 1, 2023
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_sdfg.py
Outdated
Show resolved
Hide resolved
1 task
edopao
reviewed
Dec 4, 2023
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
… -> SDFG translat) function. This leaded to some changes.
|
cscs-ci run |
|
cscs-ci run |
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
edopao
approved these changes
Dec 4, 2023
|
cscs-ci run |
philip-paul-mueller
added a commit
to philip-paul-mueller/gt4py
that referenced
this pull request
Dec 18, 2023
This commit adds a function that allows to generate the arguments needed to call an SDFG, before this was part of `run_dace_iterator()`. This made it very complex to run an SDFG outside this function. One should consider this as an amend to [PR GridTools#1379](GridTools#1379).
philip-paul-mueller
added a commit
that referenced
this pull request
Dec 19, 2023
Added a function to get the arguments to call an SDFG. This commit adds a function that allows to generate the arguments needed to call an SDFG, before this was part of `run_dace_iterator()`. This made it very complex to run an SDFG outside this function. One should consider this as an amend to [PR #1379](#1379).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it was only possible to translate ITIR to SDFG and execute it and it was not possible to extract the SDFG.
This commits splits this task into two parts and thus allows to perform the ITIR to SDFG translation without executing it.
Should be merged after #1374 .