fix[next]: Fix for GPU test execution #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edopao
requested review from
havogt and
DropD
and removed request for
havogt
DropD
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spack build of icon4py was broken because dace is an optional module, not installed in the default environment, and the dace backend is not available in test execution. This caused an
ImportErrorexception intest_gpu_backend.py, because this test is bypassing the test exclusion matrix.The initial proposed fix was to use
try/exceptto handle this case. However, all tests in baseline are already executed on GPU backends (both GTFN and DaCe), therefore this simple test is no longer needed. The final decision was to remove the test case.