fix[next]: DaCe backend - symbol propagation in lambda scope #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edopao
commented
Nov 27, 2023
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_tasklet.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_tasklet.py
Outdated
Show resolved
Hide resolved
petiaccja
suggested changes
Nov 27, 2023
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_tasklet.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_tasklet.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_tasklet.py
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_tasklet.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_tasklet.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_tasklet.py
Show resolved
Hide resolved
petiaccja
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Full-inling of ITIR
liftoperator can result in nested lambda calls, which are translated to nested SDFGs in DaCe backend. The problem was that inner lambda SDFGs were not inheriting the symbols in scope from the parent tasklet, instead the DaCe backend was only mapping the lambda arguments.The solution implemented in this PR is to run a pre-pass to discover all symbols used in the nested lambdas, and propagate the required data containers from outer to inner scope.
The legacy
visit_SymReffunction is also cleaned up. In baseline code, it was supposed to create access nodes whenever a symbol was used. With this PR, this operation is delegated to the pre-pass.This PR also contains some cleanup of the
scanvisitor. The overall goal is to rely as much as possible onvisit_FunCallto generate the scan body.