Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[next]: DaCe backend - enable GPU test execution #1360

Merged
merged 14 commits into from
Nov 23, 2023
Merged

feat[next]: DaCe backend - enable GPU test execution #1360

merged 14 commits into from
Nov 23, 2023

Conversation

edopao
Copy link
Contributor

@edopao edopao commented Nov 16, 2023 •
edited
Loading

Description

  • Small fix for GPU execution. The fix is about handling of in/out fields, for which the program argument is copied to a transient array. We need to use for the transient array the same storage as the program argument (i.e. gpu storage), otherwise code generation will throw an error because of mixed storage for inputs to the closure map.
  • Enable test execution with DACE_GPU backend
  • Minor code refactoring (test exclusion matrix, dace backend processor interface)
  • Cleanup test exclusion matrix (some left-overs after rebase of previous dace PR)

@edopao edopao marked this pull request as ready for review November 16, 2023 14:21
@edopao edopao requested a review from petiaccja November 16, 2023 14:21
@edopao edopao marked this pull request as draft November 17, 2023 16:29
@edopao edopao changed the title feat[next]: Improvements to DaCe GPU backend feat[next]: DaCe backend - enable GPU test execution Nov 20, 2023
@edopao edopao marked this pull request as ready for review November 23, 2023 08:07
kotsaloscv
kotsaloscv approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@kotsaloscv kotsaloscv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@edopao edopao merged commit 5a409c5 into GridTools:main Nov 23, 2023
@edopao edopao deleted the dace-gpu branch November 23, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotsaloscv kotsaloscv kotsaloscv approved these changes

@petiaccja petiaccja Awaiting requested review from petiaccja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edopao @kotsaloscv