test[next]: check for DaCe dependency in test execution #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b2691f5.
egparedes
reviewed
Sep 20, 2023
tests/next_tests/integration_tests/feature_tests/ffront_tests/ffront_test_utils.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/__init__.py
Outdated
Show resolved
Hide resolved
|
cscs-ci run |
2 similar comments
|
cscs-ci run |
|
cscs-ci run |
edopao
commented
Sep 21, 2023
tests/next_tests/integration_tests/multi_feature_tests/iterator_tests/test_fvm_nabla.py
Outdated
Show resolved
Hide resolved
|
@egparedes I have added the ADR and removed the duplicated fixture for ATLAS tables. Also tested with Spack on Daint. |
egparedes
approved these changes
Sep 26, 2023
ninaburg
pushed a commit
to ninaburg/gt4py
that referenced
this pull request
Oct 18, 2023
Expanding the pytest fixture for unit tests with markers to exclude tests based on feature support in the selected backend. In addition, a check is added to the DaCe backend so that tests are skipped if dace module is not installed. This is required for Spack build of icon4py, which uses the base installation of gt4py, where dace module is optional.
ninaburg
pushed a commit
to ninaburg/gt4py
that referenced
this pull request
Oct 19, 2023
Expanding the pytest fixture for unit tests with markers to exclude tests based on feature support in the selected backend. In addition, a check is added to the DaCe backend so that tests are skipped if dace module is not installed. This is required for Spack build of icon4py, which uses the base installation of gt4py, where dace module is optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code change will check if the DaCe module is available in the python environment. If not available, the DaCe backend is skipped in test execution.
Requirements
N/A