test[cartesian]: update hypothesis and fix the health check issues found in daily CI #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems that the new version caused the health check for multiple executors to trigger on parametrized tests. From the tests in hypothesis itself it looked like this might not happen if parametrization is the outer decorator (applied after @given). |
DropD
changed the title
egparedes
requested changes
Sep 7, 2023
requirements-dev.in
Outdated
| @@ -5,7 +5,7 @@ | |||
| ## for pkg in ['hypothesis', 'pytest']: | |||
| ## print(re.search(f"\n({pkg} *[=>~!].*)\n", versions)[1]) | |||
| ##]]] | |||
| hypothesis>=6.0.0 | |||
There was a problem hiding this comment.
Whenever any requirement is modified, the tox workflow updating all config files need to be executed as explained here: https://github.com/GridTools/gt4py/blob/main/docs/development/tools/requirements.md
egparedes
reviewed
Sep 12, 2023
egparedes
approved these changes
Sep 12, 2023
egparedes
force-pushed
the
fix-hypothesis-differing_executors
branch
from
2439c54 to
8c312cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The daily CI found that after updating to hypothesis 6.82.1 some tests in cartesian are failing hypothesis health checks. This PR tries to fix that.
Requirements