feat[next]: extend DaCe support of reduction operator #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding generic implementation of neighbor-reduction to DaCe backend based on map with Write-Conclict Resolution (WCR) on output memlet. Enables usee of lambdas as reduction function.
petiaccja
suggested changes
Sep 15, 2023
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_tasklet.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_tasklet.py
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace_iterator/itir_to_tasklet.py
Show resolved
Hide resolved
petiaccja
approved these changes
Sep 19, 2023
ninaburg
pushed a commit
to ninaburg/gt4py
that referenced
this pull request
Oct 18, 2023
Adding generic implementation of neighbor-reduction to DaCe backend based on map with Write-Conflict Resolution (WCR) on output memlet. This PR enables use of lambdas as reduction function.
ninaburg
pushed a commit
to ninaburg/gt4py
that referenced
this pull request
Oct 19, 2023
Adding generic implementation of neighbor-reduction to DaCe backend based on map with Write-Conflict Resolution (WCR) on output memlet. This PR enables use of lambdas as reduction function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The DaCe support in baseline of reduction operator is limited to builtin-in math operator as reduction function.
The goal of this PR to support more complex lambda functions and also addressing of neighbors in external input fields.
Requirements