Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[next]: Add FieldBuiltinFuncRegistry mixin #1330

Merged
merged 7 commits into from
Aug 31, 2023
Merged

feat[next]: Add FieldBuiltinFuncRegistry mixin #1330

merged 7 commits into from
Aug 31, 2023

Conversation

samkellerhals
Copy link
Contributor

@samkellerhals samkellerhals commented Aug 28, 2023 •
edited
Loading

Description

Adds a FieldBuiltinFuncRegistry mixin which allows subclasses to register their own builtin functions.

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder.

If this PR contains code authored by new contributors please make sure:

  • All the authors are covered by a valid contributor assignment agreement provided to ETH Zurich and signed by the employer if needed.
  • The PR contains an updated version of the AUTHORS.md file adding the names of all the new contributors.

@samkellerhals samkellerhals changed the title Add registrable decorator feat[next]: Add registrable decorator Aug 28, 2023
@samkellerhals samkellerhals requested a review from havogt August 28, 2023 13:11
havogt
havogt reviewed Aug 28, 2023
View reviewed changes
havogt
havogt reviewed Aug 28, 2023
View reviewed changes
@samkellerhals samkellerhals requested a review from havogt August 29, 2023 07:13
@samkellerhals samkellerhals changed the title feat[next]: Add registrable decorator feat[next]: Add enable_builtin_func_registry decorator Aug 29, 2023
@samkellerhals samkellerhals changed the title feat[next]: Add enable_builtin_func_registry decorator feat[next]: Add FieldBuiltinFuncRegistry mixin Aug 30, 2023
@samkellerhals samkellerhals requested a review from havogt August 30, 2023 09:43
havogt
havogt approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the flake8 exclude

@samkellerhals @havogt
Update pyproject.toml
9edaece 
Co-authored-by: Hannes Vogt <hannes@havogt.de>
@samkellerhals samkellerhals merged commit af5aa11 into GridTools:main Aug 31, 2023
@samkellerhals samkellerhals deleted the registry-decorator branch August 31, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havogt havogt havogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samkellerhals @havogt