New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat[next]: embedded.ndarray_field: field slicing and intersection #1315

Merged

samkellerhals merged 96 commits into GridTools:main from samkellerhals:domain-slicing

Aug 22, 2023

Contributor

samkellerhals commented Aug 8, 2023 •

edited by havogt

Loading

Enable slicing a Field.

Absolute slicing with a DomainSlice, a sequence of NamedRange or NamedIndex.
Relative slicing with tuple of slice or ints.

Enable binary operations on fields with different domain.

egparedes and others added 30 commits

July 24, 2023 15:17


          Add definitions and placeholders for basic embedded field view concepts

a6269f7


          Fixes

006093f


          make it pass tests

c4f9443


          save state

bf649f0


          define DomainLike

c73c296


          verify

555e9f2

wip

40a2d37


          refactor type translation

0afad47


          small fixes


          finish refactoring builtins

80c9c12


          cleanup

1475f17


          builtin tests

5ab9a54


          more tests

5df8d9d


          comments

1993f32


          cleanup

4f749ca


          fix and ignore

5555ad7


          some more qa fixes


          a few more mypy errors

87f0975


          typing

cc32ed2


          more cleanup, non-dispatch test

0e4ba03


          remove debug print

007a8d7


          reenable test

b6e91b6


          more typing fixes

b3fc186


          Suggestions and fixes

aa4c94c


          More fixes

b8279ae


          Missing changes from previous commit

c20b610


          Add docs to FieldABC

cfcb927


          fix some more typing problems

c1444f5


          fix remaining typing problems, move back registry

85b4eca


          more typing

8ead6d2

havogt reviewed

View reviewed changes

src/gt4py/next/common.py Show resolved Hide resolved

havogt reviewed

View reviewed changes

src/gt4py/next/common.py Outdated Show resolved Hide resolved

havogt reviewed

View reviewed changes

src/gt4py/next/common.py Outdated Show resolved Hide resolved

havogt reviewed

View reviewed changes

src/gt4py/next/embedded/nd_array_field.py Outdated Show resolved Hide resolved

havogt reviewed

View reviewed changes

src/gt4py/next/embedded/nd_array_field.py Outdated Show resolved Hide resolved

havogt reviewed

View reviewed changes

src/gt4py/next/embedded/nd_array_field.py Show resolved Hide resolved

havogt reviewed

View reviewed changes

src/gt4py/next/embedded/nd_array_field.py Outdated Show resolved Hide resolved

samkellerhals and others added 16 commits

August 18, 2023 11:33


          Support slice(None) in relative indexing

16541b6


          Fix _slice_range and add test

f032fae


          Cleanup

cba68e7


          more cleanup

552737b


          Handle value return relative indexing

a90fc89


          Make infinity pos neg a property

fe26ae0


          typing

69b776d


          Fix some type issues

6c1f11f


          typing

1aada7c


          fix typing

2e30a8d


          fix relative indexing

3f9a672


          fix type_conversion for Tuple[...]

36442b3


          fix deprecated classmethod property

7127de3


          restructure tests

8992f05


          cleanup comment

54c6c61


          more test refactoring

cdab8aa

havogt changed the title ~~feat[next]: embedded.ndarray_field: slice field with domain~~ feat[next]: embedded.ndarray_field: slice field

havogt changed the title ~~feat[next]: embedded.ndarray_field: slice field~~ feat[next]: embedded.ndarray_field: field slicing and intersection

samkellerhals added 2 commits

August 22, 2023 13:06


          add support for single NamedRange or NamedIndex (i.e. not in Sequence)

37dcb41


          Make NamedIndex NamedRange check more concise

c7c4955

havogt approved these changes

View reviewed changes

samkellerhals merged commit 3aaca75 into GridTools:main

samkellerhals deleted the domain-slicing branch

August 22, 2023 15:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet