Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature[next]: remap and connectivity implementations for embedded #1309

Merged
merged 90 commits into from
Nov 21, 2023
Merged

feature[next]: remap and connectivity implementations for embedded #1309

merged 90 commits into from
Nov 21, 2023

Conversation

havogt
Copy link
Contributor

@havogt havogt commented Aug 3, 2023 •
edited
Loading

Adds

  • ConnectivityField protocol
  • NdArrayFieldConnectivity for unstructured remap, CartesianConnectivity for Cartesian remap
  • implements neighbor_sum, max_over, min_over for field

TODOs for next PR:

  • support for remap with connectivities with has_skip_values=True

egparedes and others added 30 commits July 24, 2023 15:17
@egparedes
Add definitions and placeholders for basic embedded field view concepts
a6269f7
@egparedes
Fixes
006093f
@havogt
make it pass tests
c4f9443
@havogt
save state
bf649f0
@havogt
define DomainLike
c73c296
@havogt
verify
555e9f2
@havogt
wip
40a2d37
@havogt
refactor type translation
0afad47
@havogt
small fixes
0122863
@havogt
finish refactoring builtins
80c9c12
@havogt
cleanup
1475f17
@havogt
builtin tests
5ab9a54
@havogt
more tests
5df8d9d
@havogt
comments
1993f32
@havogt
cleanup
4f749ca
@havogt
fix and ignore
5555ad7
@havogt
some more qa fixes
6042750
@havogt
a few more mypy errors
87f0975
@havogt
typing
cc32ed2
@havogt
more cleanup, non-dispatch test
0e4ba03
@havogt
remove debug print
007a8d7
@havogt
reenable test
b6e91b6
@havogt
more typing fixes
b3fc186
@egparedes
Suggestions and fixes
aa4c94c
@egparedes
More fixes
b8279ae
@egparedes
Missing changes from previous commit
c20b610
@egparedes
Add docs to FieldABC
cfcb927
@havogt
fix some more typing problems
c1444f5
@havogt
fix remaining typing problems, move back registry
85b4eca
@havogt
more typing
8ead6d2
@egparedes egparedes changed the title feature[next]: Cartesian connectivity for embedded feature[next]: remap and connectivity implementations for embedded Nov 18, 2023
@havogt havogt marked this pull request as ready for review November 21, 2023 16:11
havogt
havogt commented Nov 21, 2023
View reviewed changes
egparedes
egparedes approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@egparedes egparedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ILGTM

@havogt havogt merged commit 67e5270 into GridTools:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egparedes egparedes egparedes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@havogt @egparedes @samkellerhals