feat: low-level buffer allocation utilities for new storages #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egparedes
changed the title
egparedes
changed the title
havogt
reviewed
Jul 28, 2023
src/gt4py/_core/definitions.py
Outdated
Comment on lines
428
to
431
| NDArrayObject = Union[npt.NDArray, "CuPyNDArray", "JaxNDArray", NDArrayObjectProto] | ||
| NDArrayObjectT = TypeVar( | ||
| "NDArrayObjectT", npt.NDArray, "CuPyNDArray", "JaxNDArray", NDArrayObjectProto | ||
| ) |
There was a problem hiding this comment.
remove this if mypy works for
tmp: NDArrayObjectProto = np.asarray([])
havogt
reviewed
Aug 2, 2023
Storages next hannes
egparedes
commented
Aug 4, 2023
havogt
reviewed
Aug 4, 2023
|
cscs-ci run |
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
egparedes
commented
Aug 4, 2023
|
cscs-ci run |
3 similar comments
|
cscs-ci run |
|
cscs-ci run |
|
cscs-ci run |
stubbiali
reviewed
Aug 6, 2023
havogt
reviewed
Aug 7, 2023
src/gt4py/_core/definitions.py
Outdated
Comment on lines
110
to
111
| class UnsignedIntegral(numbers.Integral): | ||
| """Abstract base class for unsigned integral types.""" |
There was a problem hiding this comment.
Suggested change
| class UnsignedIntegral(numbers.Integral): | |
| """Abstract base class for unsigned integral types.""" | |
| class PositiveIntegral(numbers.Integral): | |
| """Abstract base class representing positive integral numbers.""" |
src/gt4py/storage/allocators.py
Outdated
Comment on lines
54
to
71
| # class _NDArrayLike(Protocol): | ||
| # def __array__(self, dtype: Optional[np.dtype] = None) -> np.ndarray: | ||
| # ... | ||
|
|
||
| # def __getitem__(self, item: core_defs.SliceLike) -> np.ndarray: | ||
| # ... | ||
|
|
||
|
|
||
| # class _NDArrayLikeArrayInterface(xtyping.ArrayInterface, _NDArrayLike): | ||
| # ... | ||
|
|
||
|
|
||
| # class _NDArrayLikeCUDAArrayInterface(xtyping.CUDAArrayInterface, _NDArrayLike): | ||
| # ... | ||
|
|
||
|
|
||
| # class _NDArrayLikeDLPackBuffer(xtyping.DLPackBuffer, _NDArrayLike): | ||
| # ... |
stubbiali
reviewed
Aug 7, 2023
Co-authored-by: Stefano Ubbiali <subbiali@phys.ethz.ch>
havogt
approved these changes
Aug 8, 2023
|
Can confirm that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new buffer allocation utilities and concepts definitions.
Main changes:
Pending