Fix typing of cast_ builtin in ITIR type inference
#1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@havogt Please also take a quick look at the implication of making |
havogt
requested changes
Feb 23, 2023
Comment on lines
351
to
364
| # Note: We need to exec the stencil here since the dtype must be a type literal. | ||
| locals = {} | ||
| exec( | ||
| textwrap.dedent( | ||
| f""" | ||
| @fundef | ||
| def sten_cast(value): | ||
| return cast_(deref(value), {dtype}) | ||
| """ | ||
| ).strip(), | ||
| globals(), | ||
| locals, | ||
| ) | ||
| sten_cast = locals["sten_cast"] |
There was a problem hiding this comment.
I don't understand this change. It seems the test works without.
There was a problem hiding this comment.
Mh, previously the type checking tests failed and I (apparently) misinterpreted the reason to be located here. I works now, so I removed this change.
| @@ -477,6 +477,39 @@ def visit_FunCall( | |||
| ) | |||
| constraints.add((tup, val)) | |||
| return Val(kind=kind, dtype=elem, size=size) | |||
| if node.fun.id == "cast_": | |||
There was a problem hiding this comment.
The alternative would be to bring type of type into the typesystem, right?
There was a problem hiding this comment.
Yes, I discussed the idea with @egparedes a while ago (in the context of the frontend). I believe the conclusion was to wait until we really need this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typing inference rule for
cast_was not correctly implemented when the builtin was introduced. This PR fixes that by makingcast_part of the grammar (similar to how this is handled in the frontend). This restriction could be lifted in the future (e.g. by introducting a type of a type).