fix slot grid when the amount of slots is a prime number #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR solves the issue of
determineSlotsGrid
not taking into account that some numbers are not perfect squares or multiples of 2,3 , like prime numbersHow solved:
if the amount of input slots is not a perfect square, we raise the amount of slots to the left, if the total amount slots is still not enough we increase the amount of the bottom ( we grow the grid to the next perfect square root)
Outcome:
Returns a grid with appropriate slots for inputs with size 5,7,11.. etc
Possible compatibility issue:
None