-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Robot Arm Keep Exact functionality with item pipes #2897
Fix Robot Arm Keep Exact functionality with item pipes #2897
Conversation
a00e154
to
39e28e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic looks good but run spotlessApply
src/main/java/com/gregtechceu/gtceu/common/pipelike/item/ItemNetHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/pipelike/item/ItemNetHandler.java
Outdated
Show resolved
Hide resolved
I'll fix it tonight, thanks for feedback. |
I can confirm that KEEP_EXACT works with multiple filtered items now. Thank you. |
src/main/java/com/gregtechceu/gtceu/common/pipelike/item/ItemNetHandler.java
Outdated
Show resolved
Hide resolved
78431ae
to
49e398f
Compare
What
Fixes #2799
This PR fixes an item count calculation issue in RobotArmCover's KEEP_EXACT transfer mode. The previous implementation didn't properly verify if the items being moved matched the target slot's contents, leading to incorrect item quantity returns.
Implementation Details
isStackSpecific
parameter fromcountStack
methodItemStackHashStrategy.comparingAllButCount
)Outcome