Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overrides for builder accessors #2620

Merged
merged 2 commits into from
Dec 22, 2024
Merged

Add overrides for builder accessors #2620

merged 2 commits into from
Dec 22, 2024

Conversation

krossgg
Copy link
Contributor

@krossgg krossgg commented Dec 22, 2024

What

MachineBuilder fields which were given @Setter in #2574 were not overridden in MultiblockMachineBuilder, so were returning an object of wrong type.

@krossgg krossgg added the type: bugfix general bug fixes label Dec 22, 2024
@krossgg krossgg requested a review from a team as a code owner December 22, 2024 02:11
@krossgg krossgg added the Do Not Merge DO NOT MERGE THIS PR YET! label Dec 22, 2024
@krossgg
Copy link
Contributor Author

krossgg commented Dec 22, 2024

Has issues.
image
MachineBuilder is failing to be loaded by rhino/kjs, so when trying to find methods, it is unable to.

@krossgg krossgg removed the Do Not Merge DO NOT MERGE THIS PR YET! label Dec 22, 2024
@krossgg
Copy link
Contributor Author

krossgg commented Dec 22, 2024

Fixed by moving the blockBuilder and itemBuilder logic to static nested classes. the .color method on both of them causes Rhino to fail loading the entire class.

@screret screret merged commit 6f54826 into 1.20.1 Dec 22, 2024
3 checks passed
@screret screret deleted the kr/accessors branch December 22, 2024 07:51
omergunr100 pushed a commit to omergunr100/GregTech-Modern that referenced this pull request Dec 25, 2024
screret pushed a commit that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bugfix general bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants