Improve TagPrefix-based Recipe Generation #2616
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechLord22
added
Do Not Merge
screret
previously requested changes
Jan 4, 2025
src/main/java/com/gregtechceu/gtceu/api/data/chemical/material/properties/OreProperty.java
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/data/recipe/generated/WireRecipeHandler.java
Outdated
Show resolved
Hide resolved
krossgg
added
the
Merge on Major Release
… into tc/recipe-generation
Spicierspace153
approved these changes
Feb 21, 2025
krossgg
requested changes
Mar 4, 2025
src/main/java/com/gregtechceu/gtceu/data/recipe/generated/RecyclingRecipeHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/data/recipe/generated/ToolRecipeHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/data/recipe/generated/WireCombiningHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/data/recipe/misc/CustomToolRecipes.java
Outdated
Show resolved
Hide resolved
krossgg
requested changes
Mar 5, 2025
src/main/java/com/gregtechceu/gtceu/api/data/chemical/material/info/MaterialFlag.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/data/chemical/material/info/MaterialFlag.java
Outdated
Show resolved
Hide resolved
krossgg
approved these changes
Mar 5, 2025
screret
requested changes
Mar 5, 2025
src/main/java/com/gregtechceu/gtceu/data/recipe/generated/RecyclingRecipeHandler.java
Outdated
Show resolved
Hide resolved
krossgg
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improves TagPrefix-based Recipe Generation. Notably, this PR no longer iterates all materials for every registration handler. Instead, materials are only iterated once.
Also, fixes a bug where ores of gem materials would not forge hammer to the gem if the material had an ignored gem.
Implementation Details
GTUtil.copyAmountandGTUtil.selectItemInListto begin with.TagPrefix.MaterialRecipeHandlerandTagPrefix#executeHandler. This will require addons to update, and this PR serves as an example of how to do so.Outcome
Improves performance and cleans up recipe generation code.