Fix empty crates and drums not stacking with new ones #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spicierspace153
approved these changes
Nov 28, 2024
krossgg
changed the title
screret
pushed a commit
that referenced
this pull request
Dec 5, 2024
screret
pushed a commit
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Solves the issue with crates where they'd save an empty tag causing them not to stack with new crates.
Solves the issue with drums where they'd save a tag with an empty fluidstack causing them not to stack with new drums.
Implementation Details
Just added a check for crates to see if they're taped and for drums if they're not empty before saving the tag.
Outcome
They stack correctly when broken and still save their data otherwise.
Also
Fixes #2310