Fix data stick not copying distinct bus from me input bus #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
screret
previously requested changes
Nov 29, 2024
src/main/java/com/gregtechceu/gtceu/integration/ae2/machine/MEInputBusPartMachine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/integration/ae2/machine/MEInputBusPartMachine.java
Outdated
Show resolved
Hide resolved
YoungOnionMC
approved these changes
Dec 1, 2024
screret
approved these changes
Dec 1, 2024
screret
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: YoungOnion <39562198+YoungOnionMC@users.noreply.github.com>
screret
pushed a commit
that referenced
this pull request
Dec 28, 2024
Co-authored-by: YoungOnion <39562198+YoungOnionMC@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the distinct bus field to the copied and pasted nbt.
Suggestion
I suggest unifying the configuration copy pasting to a single interface that lets you:
(personal opinion warning)
I think the data stick interaction is a bit weird, we have a way of doing exactly that with item behaviours. (also see #2405 )
also copying on left click feels a bit clunky to me, I feel like copying on
shift + <copy key>feels better but that's just me.Also
Fixes #2344