Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combustion Engine Logic Fixes #2287

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Combustion Engine Logic Fixes #2287

merged 1 commit into from
Nov 7, 2024

Conversation

YoungOnionMC
Copy link
Member

What

Fixes #2200

Implementation Details

moves oxygen to a per tick consumption, properly scales fuel consumption, fixes lubricant timer being reset when paused

Outcome

ECEs work correctly

@YoungOnionMC YoungOnionMC requested a review from a team as a code owner November 7, 2024 22:52
@Zorbatron Zorbatron self-requested a review November 7, 2024 22:56
Copy link
Member

@Zorbatron Zorbatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YoungOnionMC YoungOnionMC added the type: bugfix general bug fixes label Nov 7, 2024
@YoungOnionMC YoungOnionMC merged commit c74f36d into 1.20.1 Nov 7, 2024
2 of 3 checks passed
@YoungOnionMC YoungOnionMC deleted the yo/combustion branch November 7, 2024 23:22
screret pushed a commit that referenced this pull request Dec 5, 2024
screret pushed a commit that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bugfix general bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extreme Combustion Engine, Liquid Oxygen consumption
2 participants