Merge pull request #235 from NotThorny/Merge-Compat #305
clippy (Linux)
5 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 5 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.81.0 (eeb90cda1 2024-09-04)
- cargo 1.81.0 (2dbb1af80 2024-08-20)
- clippy 0.1.81 (eeb90cd 2024-09-04)
Annotations
Check failure on line 40 in src/web.rs
github-actions / clippy (Linux)
called `unwrap` on `response` after checking its variant with `is_some`
error: called `unwrap` on `response` after checking its variant with `is_some`
--> src/web.rs:40:12
|
39 | if response.is_some() {
| --------------------- help: try: `if let Some(..) = response`
40 | return response.unwrap().status().as_str() == "200";
| ^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
= note: `-D clippy::unnecessary-unwrap` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_unwrap)]`
Check failure on line 697 in src/system_helpers.rs
github-actions / clippy (Linux)
current MSRV (Minimum Supported Rust Version) is `1.57.0` but this item is stable since `1.58.0`
error: current MSRV (Minimum Supported Rust Version) is `1.57.0` but this item is stable since `1.58.0`
--> src/system_helpers.rs:697:18
|
697 | while java_bin.is_symlink() {
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
Check failure on line 677 in src/system_helpers.rs
github-actions / clippy (Linux)
current MSRV (Minimum Supported Rust Version) is `1.57.0` but this item is stable since `1.58.0`
error: current MSRV (Minimum Supported Rust Version) is `1.57.0` but this item is stable since `1.58.0`
--> src/system_helpers.rs:677:18
|
677 | while java_bin.is_symlink() {
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: `-D clippy::incompatible-msrv` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::incompatible_msrv)]`
Check failure on line 69 in src/system_helpers.rs
github-actions / clippy (Linux)
method `in_terminal_noclose` is never used
error: method `in_terminal_noclose` is never used
--> src/system_helpers.rs:69:6
|
67 | trait InTerminalEmulator {
| ------------------ method in this trait
68 | fn in_terminal(&self) -> Self;
69 | fn in_terminal_noclose(&self) -> Self;
| ^^^^^^^^^^^^^^^^^^^
Check failure on line 48 in src/system_helpers.rs
github-actions / clippy (Linux)
method `as_root` is never used
error: method `as_root` is never used
--> src/system_helpers.rs:48:6
|
47 | pub trait AsRoot {
| ------ method in this trait
48 | fn as_root(&self) -> Self;
| ^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`