Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use standardized swift-async-algorithms #22

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Austinpayne
Copy link

Adopts the more common (now-a-days) swift-async-algorithms for the simple async collection needs of this package. Helps adopt the standardized ecosystem where many other packages use swift-async-algorithms.

Adopts the more common (now-a-days) swift-async-algorithms for the simple
async collection needs of this package. Helps adopt the standardized
ecosystem where many other packages use swift-async-algorithms.
@Austinpayne
Copy link
Author

@NeedleInAJayStack

@NeedleInAJayStack NeedleInAJayStack self-requested a review February 16, 2025 01:38
@NeedleInAJayStack
Copy link
Member

NeedleInAJayStack commented Feb 16, 2025

I believe if you change this line from v3 to v4, that will resolve the 'Test on Linux' check:

uses: actions/upload-artifact@v3

Copy link
Member

@NeedleInAJayStack NeedleInAJayStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @Austinpayne

Copy link
Member

@paulofaria paulofaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution! 🙂

@Austinpayne
Copy link
Author

I believe if you change this line from v3 to v4, that will resolve the 'Test on Linux' check:

uses: actions/upload-artifact@v3

Sweet, thanks! Pushed up a change to upgrade to v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants