compatibility with python 3.11

[jouve]

No description provided.

[GrahamDumpleton]

There is a competing PR for this at:

• Use inspect.Signature instead of inspect.formatargspec #203

which uses a different way.

Do you want to compare the two approaches and see if your way is easier.

I haven't had a chance to look deeply at all this yet as was on holidays for most of the past month.

[jouve]

I re-implemented formatargspec to use Signature.

this PR keep compat with py2, I think it fixes more tests cases for py3.11 and also enable the CI with py3.11-dev

[brandtbucher]

Any chance this PR could be merged and a new release cut soon? We'd like to use wrapt in our benchmark suite for measuring CPython performance improvements, but it currently doesn't work on 3.11.

[GrahamDumpleton]

Sorry, been busy with work stuff as usual. I will try and look at this weekend.

[brandtbucher]

Awesome, thanks. Please let me know if there's anything I can help with.

[GrahamDumpleton]

Not sure what is going on with GitHub, but this PR doesn't give me the option of triggering GitHub actions on it to build, verify and test the changes like is possible with #203. So I can't tell if this passes all the automated tests.

[GrahamDumpleton]

Why in some tests was code like:

args = inspect.formatargspec(*argspec)

changed to use a literal string? Eg:

args = '(cls, arg1, arg2, arg3=None, *args, **kwargs)'

https://github.com/GrahamDumpleton/wrapt/pull/205/files#diff-690566594799e4e8f81d40dd838237afec99f3eb110d48ea5352621e3d00232dL189

[jouve]

I was not sure about using formatargspec here in since wrapt.decorator calls it already if argspec is not a string (which is the test above with _wrapper_1 .

[jouve]

Not sure what is going on with GitHub, but this PR doesn't give me the option of triggering GitHub actions on it to build, verify and test the changes like is possible with #203. So I can't tell if this passes all the automated tests.

I'll force push, maybe it will unlock the CI :)

[GrahamDumpleton]

Still not helping. I will try and check out your branch, do some changes I want to make and push and see what happens with CI.

[brandtbucher]

Closing and reopening the PR might work.

[jouve]

I have the following message :

1 workflow awaiting approval
First-time contributors need a maintainer to approve running workflows. Learn more.

[GrahamDumpleton]

You can try with:

pip install wrapt==1.14.0rc1

and see if everything is okay.