-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support WASM import in Worker #15
Support WASM import in Worker #15
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
@developit ping? |
@developit Would you please check this PR? |
Sorry for they delay! This looks good, and you have tests! 🤩 |
”worker-plugin@1.1.1" doesn't bundle wasm file. (The sample code is here.)
I think it cause because
FetchCompileWasmTemplatePlugin
isn't enabled.See https://github.com/webpack/webpack/blob/v4.26.1/lib/WebpackOptionsApply.js#L110-L122.
This PR fixed it.