Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WASM import in Worker #15

Merged
merged 4 commits into from
Feb 16, 2019

Conversation

3846masa
Copy link
Contributor

@3846masa 3846masa commented Dec 3, 2018

”worker-plugin@1.1.1" doesn't bundle wasm file. (The sample code is here.)

I think it cause because FetchCompileWasmTemplatePlugin isn't enabled.
See https://github.com/webpack/webpack/blob/v4.26.1/lib/WebpackOptionsApply.js#L110-L122.

This PR fixed it.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@3846masa
Copy link
Contributor Author

3846masa commented Dec 3, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@3846masa
Copy link
Contributor Author

@developit ping?

@3846masa
Copy link
Contributor Author

@developit Would you please check this PR?

@developit
Copy link
Collaborator

Sorry for they delay! This looks good, and you have tests! 🤩

@developit developit merged commit cb00d31 into GoogleChromeLabs:master Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants