Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versatile masking #172

Merged
merged 7 commits into from
Feb 20, 2023
Merged

versatile masking #172

merged 7 commits into from
Feb 20, 2023

Conversation

MartinMohrmann
Copy link
Member

@MartinMohrmann MartinMohrmann commented Feb 17, 2023

This PR adds versatile, depth-dependent masking to GliderTools.
For example masking out all data above/below the mixed layer depth. Or above/below a constant depth. Or just the euphotic zone. Or everything above a pycnocline. The possibilities are endless!

The previous implementation was hard coded into the algorithm of the mixed layer depth algorithm. Now the masking function is versatile and can take any depth array as input. :)

  • Tests added
  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

Example image: Return all data below mixed-layer depth. How to reproduce is sufficiently documented in our .docs/physics.md, which is the basis of https://glidertools.readthedocs.io/.

image

@MartinMohrmann MartinMohrmann marked this pull request as ready for review February 17, 2023 09:15
@MartinMohrmann MartinMohrmann merged commit ee4bdf0 into GliderToolsCommunity:master Feb 20, 2023
@MartinMohrmann MartinMohrmann deleted the masking branch July 17, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants