-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
octopus-merge (part 4: rewrite tracking in plumbing) #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
bbf6df8
to
bb29cdb
Compare
Deletations that are caused by deletions higher up will now carry IDs to associate them with each other. This allows to bundle them at a later stage to re-obtain directory deletions.
Depending on the source of the rename-information, items that are children of renamed parents may be provided to enable rename tracking based on these containers, instead of always resorting to tracking leaf nodes (i.e. blobs).
Remove `tree::Changes()` and the ceremony required to diff a tree.
…n plumbing. This effectively pulls down a higher-level implementation in `gix` to the plumbing level, to allow it to be used there as well.
This merges `object::tree::diff::change::Event` into `object::tree::diff::Change` as well.
8e95d68
to
33e7cf2
Compare
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate everything on plumbing level and create a multi-tree merge with rename support.
Follow-up of #1611.
Tasks
gix
into the lower levels.gix
uses lower-level tree-diff with rewritesdiff_tree_to_tree()
to make it way easier to figure out how to perform such a diff.status()
is its own set of diffs and we could see it that way.Very Next PR
multi-tree traversal (without wildcard support!)- for now, let's just do it 'the simple' way and perform two diffsdiff3-conflict-markers
diff3-conflict-markers.sh
- be sure to capture the 'empty tree' label , but also other special casesNext PR / Outscoped
libgit2
also doesn't try it.textconv
with context, see this gist for details.GIT_DIR
set, others do.gix-command::Context
.Make blob-merge based conflict handling possible in the tree merge from- not needed for nowgix
at least.Research
Everything is about MergeORT.
merge-ORT
cannot properly handle renames within renamed directories, ending up with the source of the subdir-rename still present.git2::MergeOptions
.