Cache prepared statements #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review. 🙏 |
Pull Request Test Coverage Report for Build 14602424605Details
💛 - Coveralls |
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #257 by caching prepared statements and updating resource management across the codebase. Key updates include:
- Refactoring tests to consistently use using‑blocks when handling DbDataReader instances.
- Enhancing the prepared statement caching logic and its disposal in command execution.
- Modifying internal resource disposal patterns in both the data reader and command classes.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated usage of ExecuteReader with using‑block for proper disposal. |
| DuckDB.NET.Test/Parameters/*.cs | Wrapped ExecuteReader calls in using‑blocks or ensured explicit disposal in test cases. |
| DuckDB.NET.Data/PreparedStatement/PreparedStatement.cs | Refactored prepared statement creation and parameter binding to support caching. |
| DuckDB.NET.Data/DuckDBDataReader.cs | Updated disposal logic and managed switching from legacy enumerator to cached statement enumerator. |
| DuckDB.NET.Data/DuckDBCommand.cs | Introduced caching of prepared statements and improved disposal of cached statements to manage resources. |
Comments suppressed due to low confidence (1)
DuckDB.NET.Data/DuckDBCommand.cs:51
- [nitpick] The error message 'no open reader must exist' may be unclear; consider rewording it to 'Cannot change CommandText while a reader is open.' for improved clarity.
if (DataReader != null) throw new InvalidOperationException("no open reader must exist");
|
I've completed addressing the detected issues. 🙏 |
|
Out of curiosity, did you see any performance improvements from caching? |
|
No. In practice, I only use Appender + CTAS, and do not reuse commands, so there is no performance gain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #257.