Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: s1 用の定義を追加 #2581

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: s1 用の定義を追加 #2581

wants to merge 4 commits into from

Conversation

rito528
Copy link
Member

@rito528 rito528 commented Mar 3, 2025

debug-s1debug-pr-2115-s1 をもとに追加しました

@rito528 rito528 requested a review from outductor March 3, 2025 06:12
default = ["seichi-minecraft", "minio"]
}

resource "kubernetes_secret" "onp_minecraft_pbs_credentials" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これClusterSecret使わなかったのなんか理由ある?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@rito528 rito528 Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClusterSecret と今の定義の違いを知らないので調べます

Copy link
Member Author

@rito528 rito528 Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outductor

ClusterSecret は

resource "helm_release" "onp_minecraft_debug_minio_secrets" {
depends_on = [kubernetes_namespace.onp_seichi_debug_minecraft]
repository = "https://giganticminecraft.github.io/seichi_infra/"
chart = "raw-resources"
name = "seichi-debug-minecraft-minio-secrets"
namespace = "kube-system"
version = "0.3.0"
set_list {
name = "manifests"
value = [<<-EOS
kind: ClusterSecret
apiVersion: clustersecret.io/v1
metadata:
namespace: clustersecret
name: minio-secrets
matchNamespace:
- seichi-debug-minecraft-on-seichiassist-pr-*
data:
MINIO_ACCESS_KEY: ${base64encode(var.minio_debug_access_key)}
MINIO_ACCESS_SECRET: ${base64encode(var.minio_debug_access_secret)}
EOS
]
}
}

みたいに定義することで secret を共有できるものという認識をしましたが、すでにある namespaces-to-deploy-pbs-credentialsdefault にネームスペースを追加することでも同じようなことができるという認識でも問題ないですか? 30f6215

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

既にある namespaces-to-deploy-pbs-credentials は俺じゃなくてうんちゃまが定義したものなので知らない。

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource "kubernetes_secret"ではなく、カスタムリソースなのでまるっきり違います。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants