style(lint): fix newly created lint fails

Gh61 · Jan 25, 2024 · fa9d6cf · fa9d6cf
1 parent d727138
commit fa9d6cf
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 10 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -24,7 +24,13 @@
         "linebreak-style": ["error", "unix"],
         "@typescript-eslint/indent": ["error", 4],
         "@typescript-eslint/comma-dangle": ["error", "never"],
-        "no-underscore-dangle": ["error", { "allowAfterThis": true }],
+        // is not working very well, replace soon with https://typescript-eslint.io/rules/naming-convention/
+        "no-underscore-dangle": ["error", {
+            "allow": ["_containers", "_args", "_instance", "_isMouseDown", "_router", "__provider" ], // allow static members, private (field) getters
+            "allowAfterThis": true,
+            "enforceInMethodNames": true,
+            "allowFunctionParams": false
+        }],
         "@typescript-eslint/no-unused-expressions": ["error", { "allowShortCircuit":true }],
         "@typescript-eslint/lines-between-class-members": "off",
         "@typescript-eslint/keyword-spacing": ["error", {"overrides": { "this": { "before": false }}}],
@@ -35,6 +41,19 @@
         "import/extensions": "off",
         "import/no-extraneous-dependencies": "off",
 
+        // allow private empty ctor
+        "@typescript-eslint/no-empty-function": [
+            "error",
+            {
+                "allow": [
+                    "functions",
+                    "methods",
+                    "private-constructors",
+                    "protected-constructors"
+                ]
+            }
+        ],
+
         // unused variables for interface
         "@typescript-eslint/no-unused-vars": [
             "error",

diff --git a/src/controls/big-switch.ts b/src/controls/big-switch.ts
@@ -55,7 +55,7 @@ export class HueBigSwitch extends LitElement {
         }
     }
 
-    private _toggle() {
+    private toggle() {
         if (this.disabled) return;
         this.checked = !this.checked;
         fireEvent(this, 'change');
@@ -116,9 +116,9 @@ export class HueBigSwitch extends LitElement {
 
             this._mc.on('singletap', () => {
                 if (this.disabled) return;
-                this._toggle();
+                this.toggle();
             });
-            this.addEventListener('keydown', this._keydown);
+            this.addEventListener('keydown', this.onKeydown);
         }
     }
 
@@ -127,15 +127,15 @@ export class HueBigSwitch extends LitElement {
             this._mc.destroy();
             this._mc = undefined;
         }
-        this.removeEventListener('keydown', this._keydown);
+        this.removeEventListener('keydown', this.onKeydown);
     }
 
-    private _keydown(ev: KeyboardEvent) {
+    private onKeydown(ev: KeyboardEvent) {
         if (ev.key !== 'Enter' && ev.key !== ' ') {
             return;
         }
         ev.preventDefault();
-        this._toggle();
+        this.toggle();
     }
 
     protected override render(): TemplateResult {

diff --git a/src/controls/color-temp-picker.ts b/src/controls/color-temp-picker.ts
@@ -136,8 +136,8 @@ export class HueColorTempPicker extends LitElement {
         this._isRendered = true;
     }
 
-    protected override updated(_changedProperties: PropertyValues<HueColorTempPicker>): void {
-        if (_changedProperties.has('mode') && _changedProperties.get('mode')) {
+    protected override updated(changedProperties: PropertyValues<HueColorTempPicker>): void {
+        if (changedProperties.has('mode') && changedProperties.get('mode')) {
             this.drawWheel();
         }
     }

diff --git a/src/core/hass-text-template.ts b/src/core/hass-text-template.ts
@@ -74,7 +74,7 @@ export class StaticTextTemplate implements IHassTextTemplate {
         this._text = text;
     }
 
-    public resolveToString(_hass: HomeAssistant | null = null): string {
+    public resolveToString(): string {
         return this._text;
     }