Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Delete and redraft #1310

Open
1 task done
xplosionmind opened this issue Jan 26, 2025 · 6 comments · May be fixed by #1313
Open
1 task done

[Request]: Delete and redraft #1310

xplosionmind opened this issue Jan 26, 2025 · 6 comments · May be fixed by #1313
Labels
enhancement New feature or request

Comments

@xplosionmind
Copy link

Describe the request

It would be great to have a “Delete and redraft” button alongside the “Delete” one, so that the content of the post that is being deleted is automatically pasted in a new draft.

Implementation Details

@xplosionmind xplosionmind added the enhancement New feature or request label Jan 26, 2025
@GeopJr
Copy link
Owner

GeopJr commented Jan 26, 2025

Internally, Tuba supports this, but I have to ask, is there a reason you'd want that over editing?

I never bothered to enable it because I added editing when I first forked tootle. I know some backends don't support editing, but most should. Maybe I can add a special case for them instead if that's the reason?

To me, editing feels like a Delete & Redraft replacement (which, as long time fedi users might remember, was the only way to 'edit' posts prior to editing becoming a thing)

@GeopJr
Copy link
Owner

GeopJr commented Jan 26, 2025

How about a checkbox or an additional button on the delete dialog?


  Delete Post?
   ✅ Redraft
[Cancel] [Delete]

Delete Post?
  [Delete]
  [Redraft]
  [Cancel]

I think the latter better matches the hig

@xplosionmind
Copy link
Author

is there a reason you'd want that over editing?

Since an edited post is labelled as “edited”, if there is just a typo in a post that has been just published, I usually prefer to delete and re-draft it.

Maybe I can add a special case for them instead if that's the reason?

Not really… it’s more to give users the choice of the option they prefer. Since most mobile clients have this feature, I got used to taking advantage of it.

@xplosionmind
Copy link
Author

xplosionmind commented Jan 27, 2025

I think the latter better matches the hig

I totally agree! One less click.

@GeopJr GeopJr linked a pull request Jan 27, 2025 that will close this issue
@GeopJr
Copy link
Owner

GeopJr commented Jan 27, 2025

I know the name is Delete & Redraft, but I was hoping I could Redraft & Delete instead as it's less 'dangerous'. However that doesn't seem to be the case.

If the old post exists then stuff like changing alt text won't work because the attachment ID it belongs to already exists.

So our options are either Delete first and Redraft afterwards or hack it together and only apply alt texts and similar when the user clicks redraft by deleting the post before actually redrafting it.

I don't like either to be honest :(

The first one would require us to have 2 red (dangerous) buttons which I believe goes against hig. So we probably have to scrap this design and go with the first from #1310 (comment) (the checkbox one)

This is what it looks like rn:

Image

Image

And the second one is too hacky and I can already sense the race conditions with the instance :/

@xplosionmind
Copy link
Author

Thank you for experimenting with this, @GeopJr! Unfortunately, I don’t think I can help with these specific technicalities, especially because I am not too familiar with the best hig and UI/UX practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants