Speed up build #59
Merged
Speed up build #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speeds up assembly from ~2 minutes to ~25 seconds
Slightly faster: ~5.443s -> ~4.813s
Reduces assemble time by 6 seconds
makamys
changed the title
eigenraven
reviewed
Feb 15, 2024
Avoids early dependency resolution
eigenraven
reviewed
Feb 15, 2024
eigenraven
approved these changes
Feb 15, 2024
This was referenced Feb 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits
:retrofuturagradle's shadow task into separate tasks for source and dependency shadowing. Now only the main sourceset's classes get relocated on every build. This speeds up assembly from ~2 minutes to ~25 seconds.It's somewhat messy but I'm not sure if there's a better way to implement this. It could be simplified a bit by removing the
shadowJartask since it does nothing now.Known differences:
com.gtnewhorizons.retrofuturagradle.shadow.com.gtnewhorizons.retrofuturagradle.fg23shadow.*is now simplycom.gtnewhorizons.retrofuturagradle.fg23shadow.*)jdtAdapterCompiler.jaris now missing for some reason.Update: I also added an option to skip the javadoc task since it takes 6 seconds for me.