Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Client crashes when inserting renamed crafting module into chassis. #82

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Fix: Client crashes when inserting renamed crafting module into chassis. #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f494779
Fix: Client crashes when inserting renamed crafting module into chassis.
godrja Mar 9, 2025
d08a7d3
Spottlessified ItemModuleInformationManager
godrja Mar 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions src/main/java/logisticspipes/logisticspipes/ItemModuleInformationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
package logisticspipes.logisticspipes;

import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import java.util.Map;
import java.util.Random;

import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTBase;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.nbt.NBTTagString;
Expand Down Expand Up @@ -78,21 +79,22 @@ public static void readInformation(ItemStack itemStack, LogisticsModule module)
}
}

public static void removeInformation(ItemStack itemStack) {
if (itemStack == null) {
/**
* Remove mod-specific NBT tags from the given ItemStack.
*/
public static void removeInformation(final ItemStack itemStack) {
if (itemStack == null || !itemStack.hasTagCompound()) {
return;
}
if (itemStack.hasTagCompound()) {
NBTTagCompound nbt = itemStack.getTagCompound();

final NBTTagCompound nbtCopy = new NBTTagCompound();
for (Object e : itemStack.getTagCompound().tagMap.entrySet()) {
@SuppressWarnings("unchecked")
Collection<String> collection = nbt.tagMap.keySet();
nbt = new NBTTagCompound();
for (String key : collection) {
if (!ItemModuleInformationManager.Filter.contains(key)) {
nbt.setTag(key, nbt.getTag(key));
}
final Map.Entry<String, NBTBase> entry = (Map.Entry<String, NBTBase>) e;
if (!ItemModuleInformationManager.Filter.contains(entry.getKey())) {
nbtCopy.setTag(entry.getKey(), entry.getValue());
}
itemStack.setTagCompound(nbt);
}
itemStack.setTagCompound(nbtCopy);
}
}