refactor: Use MethodHandle to prevent autoboxing allocations #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With MethodHandle.invokeExact we can skip the autoboxing allocations from the BCRenderTESR when looking at logistic pipes. These allocations accounted for 5MB+ over a minute in a test world. Co-authored-by: Raven Szewczyk <git@eigenraven.me>
eigenraven
reviewed
May 20, 2024
src/main/java/logisticspipes/proxy/buildcraft/BCRenderTESR.java
Outdated
Show resolved
Hide resolved
eigenraven
reviewed
May 20, 2024
src/main/java/logisticspipes/proxy/buildcraft/BCRenderTESR.java
Outdated
Show resolved
Hide resolved
eigenraven
approved these changes
May 20, 2024
Dream-Master
pushed a commit
that referenced
this pull request
May 20, 2024
* refactor: Use MethodHandle to prevent autoboxing allocations With MethodHandle.invokeExact we can skip the autoboxing allocations from the BCRenderTESR when looking at logistic pipes. These allocations accounted for 5MB+ over a minute in a test world. Co-authored-by: Raven Szewczyk <git@eigenraven.me> * Make MethodHandles static * cleanup: Replace try/catch with @SneakyThrows and use varargs instead of array --------- Co-authored-by: Raven Szewczyk <git@eigenraven.me> (cherry picked from commit e3774f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With MethodHandle.invokeExact we can skip the autoboxing allocations from the BCRenderTESR when a player is looking at logistic pipes. These allocations accounted for 5MB+ over a minute in a test world.