cleanup: Skip unnecessary NBT copying when checking for Item class #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can take the underlying `Item` from an `ItemIdentifierStack` directly without converting to an `ItemStack` first. The temporary `ItemStack` is heavy-weight for fluids since the fluid/amount is stored in an NBT that has to be copied.
boubou19
approved these changes
May 20, 2024
Dream-Master
pushed a commit
that referenced
this pull request
May 20, 2024
We can take the underlying `Item` from an `ItemIdentifierStack` directly without converting to an `ItemStack` first. The temporary `ItemStack` is heavy-weight for fluids since the fluid/amount is stored in an NBT that has to be copied. (cherry picked from commit 4960669)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can take the underlying
Itemfrom anItemIdentifierStackdirectly without converting to anItemStackfirst. The temporaryItemStackis heavy-weight for fluids since the fluid/amount is stored in an NBT that has to be copied.