fix: Drastically reduce number of display lists when transporting fluids #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogisticsNewPipeItemBoxRenderer has a display list cache for rendering fluids. Unfortunately there is a small bug/typo where a `FluidStack` is used as the key for lookup, but a `FluidIdentifier` is used for writing the cached display list array. Essentially, the cache is unused and we create a fresh display list for every traveling liquid box in every frame. To fix, we simply use the FluidIdentifier consistently. This should help with FPS in networks with lots of (vsibily) traveling fluids.
boubou19
approved these changes
May 20, 2024
Dream-Master
pushed a commit
that referenced
this pull request
May 20, 2024
…ids (#45) LogisticsNewPipeItemBoxRenderer has a display list cache for rendering fluids. Unfortunately there is a small bug/typo where a `FluidStack` is used as the key for lookup, but a `FluidIdentifier` is used for writing the cached display list array. Essentially, the cache is unused and we create a fresh display list for every traveling liquid box in every frame. To fix, we simply use the FluidIdentifier consistently. This should help with FPS in networks with lots of (vsibily) traveling fluids. (cherry picked from commit 3848737)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogisticsNewPipeItemBoxRenderer has a display list cache for rendering fluids. Unfortunately there is a small bug/typo where a
FluidStackis used as the key for lookup, but aFluidIdentifieris used for writing the cached display list array.Essentially, the cache is unused and we create a fresh display list for every traveling liquid box in every frame.
To fix, we simply use the FluidIdentifier consistently. This should help with FPS in networks with lots of (vsibily) traveling fluids.