cleanup: LogisticsNewPipeItemBoxRenderer takes an ItemIdentifierStack #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For doRenderItem there is no need to convert first to an ItemStack and then back to an ItemIdentifierStack on the hotpath if we can just pass the ItemIdentifierStack directly. This is a follow up to GTNewHorizons#40.
|
@szuend are you on GTNH discord? I have a few questions about LP mod since you pushed a few fixes guess you know the codebase. |
boubou19
approved these changes
May 20, 2024
|
@Dream-Master My GTNH discord username is "nimodota" :) But to be fair, I don't really know the code base. I just attached a profiler to LP and fixed some of the easier performance / GC problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For doRenderItem there is no need to convert first to an ItemStack and then back to an ItemIdentifierStack on the hotpath if we can just pass the ItemIdentifierStack directly.
This is a follow up to #40.