cleanup: Skip unused string concatenation #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`updateEntity` in `LogisticsTileGenericPipe` currently creates a debug string that goes unused in normal release builds. We can skip allocating temporary `StringBuilder` instances by checking the DEBUG flag directly. Normally we'd use a format string with an additional varargs argument, but the `add(Super)TraceInformation` methods already use a varargs parameter to pass nested `Infos`. This is the pragmatic, cheap way to remove the calls from the hot path.
OneEyeMaker
approved these changes
May 19, 2024
Dream-Master
pushed a commit
that referenced
this pull request
May 20, 2024
`updateEntity` in `LogisticsTileGenericPipe` currently creates a debug string that goes unused in normal release builds. We can skip allocating temporary `StringBuilder` instances by checking the DEBUG flag directly. Normally we'd use a format string with an additional varargs argument, but the `add(Super)TraceInformation` methods already use a varargs parameter to pass nested `Infos`. This is the pragmatic, cheap way to remove the calls from the hot path. (cherry picked from commit 23f83a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateEntityinLogisticsTileGenericPipecurrently creates debug strings that go unused in normal release builds. We can skip allocating temporaryStringBuilderinstances by checking the DEBUG flag directly.Normally we'd use a format string with an additional varargs argument, but the
add(Super)TraceInformationmethods already use a varargs parameter to pass nestedInfos. This is the pragmatic, cheap way to remove the calls from the hot path.