Fix Logistic Pipes Storage Drawer Functionality #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logistic Pipes are able to insert into Storage Drawer Controllers. However, they do not respect already existing items in the drawers. Instead ALWAYS preferring closer empty drawers to further away reserved drawers. This change brings parity to Logistic Pipes such that it will try and insert an item into a further away drawer before pushing into a closer empty drawer. This "mergePass" implementation is same implementation style that Project Red pipes use.
OneEyeMaker
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logistic Pipes are able to insert into Storage Drawer Controllers.
However, they do not respect already existing items in the drawers. Instead ALWAYS preferring closer empty drawers to further away reserved drawers.
This change brings parity to Logistic Pipes (with other piping mods) such that it will try and insert an item into a reserved but further away drawer before pushing into a closer empty drawer. This "mergePass" implementation is same implementation style that Project Red pipes use.