Only render overlay in post #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dream-Master
added
the
🚧 Testing on Zeta
serenibyss
approved these changes
Mar 3, 2025
serenibyss
removed
the
🚧 Testing on Zeta
|
this crash the server zeta when try to join @RecursivePineapple |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the overlay renderer runs twice: once for the pre event, and once for the post event. This PR changes the subscriber to only render in the post event. This is a minor performance improvement, but it's not anything measurable. It's just something I noticed when profiling containers with a lot of enchanted items. This is very low risk since it was already rendering in the post event, I just removed the pre event.
Before:
https://spark.lucko.me/j6XJrUzYht
After:
https://spark.lucko.me/SM6oLuddU8