Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an interface for meta- and nbt-aware music disks to fix modded disk support in electric jukeboxes #96

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

eigenraven
Copy link
Member

First part of fixing GTNewHorizons/GT-New-Horizons-Modpack#18055 - adding a standardized interface to list all music disks and get the sound resources corresponding to each disk, even for NBT and metadata-powered disks.

@eigenraven eigenraven requested a review from a team December 9, 2024 18:45
@eigenraven eigenraven self-assigned this Dec 9, 2024
@eigenraven eigenraven merged commit a97a445 into master Dec 9, 2024
1 check passed
@eigenraven eigenraven deleted the raven/music-disc-api branch December 9, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants